mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 59074: Updated all tests that use Containerizer::launch(...).
Date Thu, 11 May 2017 16:05:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59074/#review174666
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/hook_tests.cpp
Lines 303 (patched)
<https://reviews.apache.org/r/59074/#comment247869>

    Why you need this?


- Jie Yu


On May 11, 2017, 12:27 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59074/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 12:27 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7304 and MESOS-7449
>     https://issues.apache.org/jira/browse/MESOS-7304
>     https://issues.apache.org/jira/browse/MESOS-7449
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This sweeps through the unit tests and translates all existing
> tests that use the two variants of Containerizer::launch(...)
> (i.e. nested and non-nested) and translates the arguments to the
> new interface.  Some of the fetcher interface changes are also
> addressed in this sweep.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09 
>   src/tests/check_tests.cpp ec0d5ee78a94991c68f38174d09b41e8f2e4be35 
>   src/tests/command_executor_tests.cpp da4b653303d436309f6cb190ad6b600b8d934678 
>   src/tests/container_logger_tests.cpp 28436b6b67c1251d877064751e695c6696725a23 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 4e1d027bde7f0ab51e778bfd3bac8797fc7f7f1b

>   src/tests/containerizer/cni_isolator_tests.cpp 565e58ae75e918453e4386f5e35a5a844a8b15f8

>   src/tests/containerizer/composing_containerizer_tests.cpp d7fd6216080f2f437503b898bff6b1046317933e

>   src/tests/containerizer/cpu_isolator_tests.cpp 3c6f7481de2d6d1f6abf9850bd33cea44931480a

>   src/tests/containerizer/docker_volume_isolator_tests.cpp b47a6b5081a63ac474ac4634701b1a572eb58137

>   src/tests/containerizer/isolator_tests.cpp 355e15ff69ca6bdd94821f6566fd09a280d03b47

>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 70a0dce0f0166fcb3c15a03a89151152954abbac

>   src/tests/containerizer/memory_isolator_tests.cpp 0df4aa892b531eb305eb3012862ad25527344ab6

>   src/tests/containerizer/memory_pressure_tests.cpp c4ad779906ee31d07fdd8a6fc0e51e1edd1cbe85

>   src/tests/containerizer/port_mapping_tests.cpp a528382e8b4831b9c7e8dcc877a5e242909f0cd5

>   src/tests/containerizer/volume_image_isolator_tests.cpp ad1884459e87ece767e1019adcf702a2f2ff8f1c

>   src/tests/containerizer/xfs_quota_tests.cpp 7beb60b059910a0d4451b1ace895a35dc974a043

>   src/tests/disk_quota_tests.cpp f758bee07c448afe09dc380e99c4a81e2dd9f650 
>   src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad 
>   src/tests/hook_tests.cpp 02d8f800c3eb9b1e617a14c78c2ef1e45d1c72bb 
>   src/tests/master_tests.cpp ceee2f4a5d38e0f4200f444769e058d2173de821 
>   src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11 
>   src/tests/slave_tests.cpp 8c97dc6d088708d301dc3ccf90d413fd785b782f 
> 
> 
> Diff: https://reviews.apache.org/r/59074/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> Currently fails a few of the fetcher tests, which might need tweaking (these tests assume
the fetcher caches things in the current directory):
> ```
> [  FAILED  ] FetcherTest.RelativeFilePath
> [  FAILED  ] FetcherCacheTest.SimpleEviction
> [  FAILED  ] FetcherCacheTest.FallbackFromEviction
> [  FAILED  ] FetcherCacheTest.RemoveLRUCacheEntries
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message