mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 58905: Changed naming of Docker containers to the pre-0.23 scheme.
Date Thu, 11 May 2017 13:08:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58905/#review174641
-----------------------------------------------------------




src/slave/containerizer/docker.hpp
Line 318 (original), 319 (patched)
<https://reviews.apache.org/r/58905/#comment247845>

    Have you considered the case where we can call 'usage' or 'update' after upgrade. Will
the new code be able to handle old containers given the naming scheme has been changed?


- Jie Yu


On May 2, 2017, 2:05 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58905/
> -----------------------------------------------------------
> 
> (Updated May 2, 2017, 2:05 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7449
>     https://issues.apache.org/jira/browse/MESOS-7449
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The choice of naming scheme is cosmetic.  All versions of the Docker
> containerizer will consider containers starting with "mesos-"
> as containers started by Mesos.  The Docker containerizer does not
> consider the `SlaveID` at all when recovering.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp 44efa44586455df416fc9cdc51c92bd9027f24c3 
>   src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7 
> 
> 
> Diff: https://reviews.apache.org/r/58905/diff/1/
> 
> 
> Testing
> -------
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message