mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 58967: Set the working directory to parent task's for DEBUG containers.
Date Thu, 11 May 2017 10:07:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58967/
-----------------------------------------------------------

(Updated May 11, 2017, 10:07 a.m.)


Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone.


Changes
-------

Removed unicode char.


Bugs: MESOS-7433
    https://issues.apache.org/jira/browse/MESOS-7433


Repository: mesos


Description
-------

A DEBUG container's working directory should be set to the parent
task's working directory. For the command executor case, even if
the task itself has a root filesystem, the executor container still
uses the host filesystem, hence
`ContainerLaunchInfo.working_directory`, pointing to the executor's
working directory in the host filesystem, may be different from the
task's working directory in the root filesystem.


Diffs (updated)
-----

  include/mesos/slave/containerizer.proto 41f2905df690bfe88ed762f1cd1246689fa4d3ea 
  src/slave/containerizer/mesos/containerizer.cpp dd3a0705d98c75078c1c363317def5d801844e4a



Diff: https://reviews.apache.org/r/58967/diff/4/

Changes: https://reviews.apache.org/r/58967/diff/3-4/


Testing
-------

make check on Mac OS and Fedora 24


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message