mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Janiszewski <jani...@gmail.com>
Subject Re: Review Request 58874: Stripped spaces between directory elements in WebUI.
Date Thu, 11 May 2017 08:35:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58874/#review174615
-----------------------------------------------------------




src/webui/master/static/browse.html
Lines 17-20 (original), 17-20 (patched)
<https://reviews.apache.org/r/58874/#comment247820>

    How about usign `<span>` here instead of list? Then `/` will be just visible text
and then copyalbe whitouth hacks with zero sized text.
    
    I haven't tested this but below code is what I think it could look like.
    ```
    <div class="breadcrunb">
      <span ng-repeat="dir in path.split('/')">
         <a href="#/agents/{{agent_id}}/browse?path={{
                encodeURIComponent(path.split('/').slice(0, $index + 1).join('/'))
                }}">
                    {{dir}}
         </a>
         <span>/</span>
      </span>
    </div>
    ```


- Tomasz Janiszewski


On Maj 8, 2017, 8:01 rano, haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58874/
> -----------------------------------------------------------
> 
> (Updated Maj 8, 2017, 8:01 rano)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Bugs: MESOS-7468
>     https://issues.apache.org/jira/browse/MESOS-7468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stripped spaces between directory elements in WebUI.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/browse.html b9849197227b06df348789a49348e2b5d4cfd2ae 
>   src/webui/master/static/css/mesos.css 9f3de5427071fc61d3791c4bc2a660368c2cd3c2 
> 
> 
> Diff: https://reviews.apache.org/r/58874/diff/3/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> strip_space.gif
>   https://reviews.apache.org/media/uploaded/files/2017/05/03/79afd0b1-5fb1-437c-a91c-732009af8fe3__strip_space.gif
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message