mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 59116: Windows: Updated `support/windows-build.bat`.
Date Thu, 11 May 2017 02:54:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59116/#review174598
-----------------------------------------------------------



Patch looks great!

Reviews applied: [59155, 59156, 59157, 59116]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 10, 2017, 8:40 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59116/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 8:40 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-7343
>     https://issues.apache.org/jira/browse/MESOS-7343
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It now understands the environment variable `CMAKE_GENERATOR` so that
> users can change the generator; the default is still Visual Studio 14.
> 
> Direct usage of `msbuild` was replaced with `cmake --build`.
> 
> We now build `mesos-tests` in the same pattern as `stout-tests` and
> `libprocess-tests`. If admin priveleges are missing, we skip running the
> tests, but still proceed to build the general target.
> 
> We set the CMake toolset instead of an environment variable for
> `PreferredToolArchitecture`.
> 
> 
> Diffs
> -----
> 
>   support/windows-build.bat 88e177ced912b61f8169b58a50d1cf6ba0c4c0c7 
> 
> 
> Diff: https://reviews.apache.org/r/59116/diff/1/
> 
> 
> Testing
> -------
> 
> Built and tested script with clean build on Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message