mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 58967: Set the working directory to parent task's for DEBUG containers.
Date Wed, 10 May 2017 21:58:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58967/#review174573
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/slave/containerizer.proto
Line 194 (original), 194 (patched)
<https://reviews.apache.org/r/58967/#comment247724>

    Looks like some random unicode char at the end?


- Vinod Kone


On May 10, 2017, 1:56 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58967/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 1:56 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7433
>     https://issues.apache.org/jira/browse/MESOS-7433
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A DEBUG container's working directory should be set to the parent
> task's working directory. For the command executor case, even if
> the task itself has a root filesystem, the executor container still
> uses the host filesystem, hence
> `ContainerLaunchInfo.working_directory`, pointing to the executor's
> working directory in the host filesystem, may be different from the
> task's working directory in the root filesystem.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/containerizer.proto 41f2905df690bfe88ed762f1cd1246689fa4d3ea 
>   src/slave/containerizer/mesos/containerizer.cpp 3d724945812c0359ed175ce232f70886dc4401c8

> 
> 
> Diff: https://reviews.apache.org/r/58967/diff/3/
> 
> 
> Testing
> -------
> 
> make check on Mac OS and Fedora 24
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message