mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 59017: Added support for docker spec helper 'parseAuthConfig()'.
Date Wed, 10 May 2017 18:22:36 GMT


> On May 9, 2017, 11:25 p.m., Vinod Kone wrote:
> > include/mesos/docker/spec.hpp
> > Lines 83 (patched)
> > <https://reviews.apache.org/r/59017/diff/1/?file=1709140#file1709140line83>
> >
> >     no unit test for this?
> 
> Gilbert Song wrote:
>     This helper was tested in unit test when the parameter is a JSON object. Thought
no duplicate unit test needed for the `string` parameter since they are the same implementation.

Since the string version calls the JSON version, how about just testing the string version
instead so we have both functions covered?


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59017/#review174398
-----------------------------------------------------------


On May 10, 2017, 12:47 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59017/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 12:47 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff,
and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
>     https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for docker spec helper 'parseAuthConfig()'.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03 
>   src/docker/spec.cpp 6b5588e534215451593cc20011847c3abbab9b17 
> 
> 
> Diff: https://reviews.apache.org/r/59017/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message