mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 59140: Fixed task_environment serializing in containerizer.
Date Wed, 10 May 2017 13:28:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59140/#review174469
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/containerizer.cpp
Lines 1371-1377 (patched)
<https://reviews.apache.org/r/59140/#comment247636>

    Let's add a helper to common/protobuf_utils.cpp `createEnvironment`


- Jie Yu


On May 10, 2017, 12:34 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59140/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 12:34 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 3d724945812c0359ed175ce232f70886dc4401c8

> 
> 
> Diff: https://reviews.apache.org/r/59140/diff/1/
> 
> 
> Testing
> -------
> 
> make check and functional testing.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message