-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59092/#review174451
-----------------------------------------------------------
src/resource_provider/local_driver.cpp
Lines 19-25 (patched)
<https://reviews.apache.org/r/59092/#comment247622>
These should be sorted alphabetically. I.e. the `mesos` includes come first.
src/resource_provider/local_driver.cpp
Lines 27-38 (patched)
<https://reviews.apache.org/r/59092/#comment247625>
Sort these as well.
src/resource_provider/local_driver.cpp
Lines 66 (patched)
<https://reviews.apache.org/r/59092/#comment247627>
How about we add a log line here, to be able to debug these cases? E.g. `MesosSchedulerDriver`
would `VLOG(1)` in such a case.
Here and below.
- Jan Schlicht
On May 9, 2017, 3:48 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59092/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 3:48 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Bugs: MESOS-7469
> https://issues.apache.org/jira/browse/MESOS-7469
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The local resource provider driver will be used by local resource
> providers. It relies on the agent's connection to the master. The
> agent will be responsible for forwarding Events and Calls by invoking
> corresponding functions from this driver.
>
>
> Diffs
> -----
>
> include/mesos/v1/resource_provider.hpp PRE-CREATION
> include/mesos/v1/resource_provider/resource_provider.hpp 2b8c8afab852621fb49b132813d512d0c96bc68c
> src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9
> src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a
> src/resource_provider/local_driver.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/59092/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
|