mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 58821: Added a test that verifies a task and its check share the work dir.
Date Wed, 10 May 2017 12:22:45 GMT


> On May 9, 2017, 9:17 p.m., Vinod Kone wrote:
> > src/tests/check_tests.cpp
> > Lines 706-730 (patched)
> > <https://reviews.apache.org/r/58821/diff/4/?file=1711319#file1711319line706>
> >
> >     I wonder if it might be better to improve the check command instead of doing
this (is there a guarantee that the file exists by the second check update?) For example the
check command could wait until the file exists in a while loop and we can rely on the check
timeout to break the loop incase of a failure.

Yes, there is a guarantee, that the file exists when we get the second update. Indeed, the
second check might not see the file, but in this case no check status update is sent.

We can change the test so that the check command only returns when the file exists. In this
case both approaches achieve the same thing. I'm slightly inclined to keep the current one
because it gives a reader a better understanding about the check mechanics.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58821/#review174378
-----------------------------------------------------------


On May 9, 2017, 2:32 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58821/
> -----------------------------------------------------------
> 
> (Updated May 9, 2017, 2:32 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7433
>     https://issues.apache.org/jira/browse/MESOS-7433
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/check_tests.cpp ec0d5ee78a94991c68f38174d09b41e8f2e4be35 
> 
> 
> Diff: https://reviews.apache.org/r/58821/diff/4/
> 
> 
> Testing
> -------
> 
> `make check` on Mac OS and Fedora 24
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message