mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 59105: Allowed leading zeros in input to stout's Version parser.
Date Wed, 10 May 2017 04:08:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59105/
-----------------------------------------------------------

(Updated May 10, 2017, 4:08 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Split comment changes to a separate review.


Bugs: MESOS-7464
    https://issues.apache.org/jira/browse/MESOS-7464


Repository: mesos


Description
-------

The original behavior was to allow leading zeros. When Version was
enhanced with more complete support for SemVer [1], it was also changed
to reject leading zeros in numeric components (version numbers and
prerelease identifiers). Although this change was consistent with the
SemVer spec (which mandates that such version strings "MUST" be
considered invalid), it breaks compatibility with the versions used by
some common software packages (e.g., Docker).

This commit reverts the change in behavior, so that leading zeros are
once again allowed. In the future, we might consider adding a "strict"
mode to the Version parser, and/or supporting an "options" scheme that
would allow the user to customize the version parser's behavior.

[1] 287556284d76e03c11cff3fc076224fe966096e0


Diffs (updated)
-----

  3rdparty/stout/include/stout/version.hpp 4be722208329f838a3a3ebaa3b44affb2a6905f4 
  3rdparty/stout/tests/version_tests.cpp bce185ec493054ec81d0764088d04f3e4147303d 


Diff: https://reviews.apache.org/r/59105/diff/2/

Changes: https://reviews.apache.org/r/59105/diff/1-2/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message