mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 59105: Allowed leading zeros in input to stout's Version parser.
Date Wed, 10 May 2017 00:34:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59105/#review174401
-----------------------------------------------------------


Fix it, then Ship it!




Sorry, didn't see this until Adam pinged me, I'm a bit behind on email. :)


3rdparty/stout/include/stout/version.hpp
Lines 53-57 (patched)
<https://reviews.apache.org/r/59105/#comment247536>

    Why move this comment down in this patch? Seems unrelated


- Benjamin Mahler


On May 9, 2017, 6:29 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59105/
> -----------------------------------------------------------
> 
> (Updated May 9, 2017, 6:29 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7464
>     https://issues.apache.org/jira/browse/MESOS-7464
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The original behavior was to allow leading zeros. When Version was
> enhanced with more complete support for SemVer [1], it was also changed
> to reject leading zeros in numeric components (version numbers and
> prerelease identifiers). Although this change was consistent with the
> SemVer spec (which mandates that such version strings "MUST" be
> considered invalid), it breaks compatibility with the versions used by
> some common software packages (e.g., Docker).
> 
> This commit reverts the change in behavior, so that leading zeros are
> once again allowed. In the future, we might consider adding a "strict"
> mode to the Version parser, and/or supporting an "options" scheme that
> would allow the user to customize the version parser's behavior.
> 
> [1] 287556284d76e03c11cff3fc076224fe966096e0
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/version.hpp 9120e42eedcfb4fc5ee41f08354441bc10914baf 
>   3rdparty/stout/tests/version_tests.cpp bce185ec493054ec81d0764088d04f3e4147303d 
> 
> 
> Diff: https://reviews.apache.org/r/59105/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message