mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 59078: Fixed the MULTI_ROLE upgrade path for an old master and new agent.
Date Tue, 09 May 2017 21:04:04 GMT


> On May 9, 2017, 8:49 p.m., Michael Park wrote:
> > src/slave/slave.cpp
> > Line 4997 (original), 4997-4998 (patched)
> > <https://reviews.apache.org/r/59078/diff/1/?file=1711711#file1711711line4997>
> >
> >     Maybe mention here that if the task does not have an allocation role, both `ExecutorInfo`
and `TaskInfo` will have the allocation role injected later?

Sounds good.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59078/#review174372
-----------------------------------------------------------


On May 9, 2017, 7:16 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59078/
> -----------------------------------------------------------
> 
> (Updated May 9, 2017, 7:16 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-7478
>     https://issues.apache.org/jira/browse/MESOS-7478
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The agent was accidentally assuming that the task sent by the master
> had the `allocation_info` set. The fix is for `getExecutorInfo` to
> inject only in the case where it is already set.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp a37c6c888e7573209aadb07576cfb727fa1ec4ff 
> 
> 
> Diff: https://reviews.apache.org/r/59078/diff/1/
> 
> 
> Testing
> -------
> 
> Manually performed upgrade tests:
> 
> 1.2.0 agent with 1.1.0 master, crashes as MESOS-7478
> HEAD+fix with 1.1.0 master, works
> 1.2.x+fix with 1.1.0 master, works
> 1.1.0 master with 1.1.0 agent, then upgrade agent to 1.2.x+fix works
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message