mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 59110: Fixed `Version::validateIdentifier()` for Unicode edge case.
Date Tue, 09 May 2017 20:32:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59110/
-----------------------------------------------------------

Review request for mesos, Li Li and Neil Conway.


Bugs: MESOS-7484
    https://issues.apache.org/jira/browse/MESOS-7484


Repository: mesos


Description
-------

The test case `u8"1.0.0-b\u00e9ta"` in `VersionTest.ParseInvalid` caused
an abort in `isctype.cpp` with VS 2017. Changing the `char` to an
`unsigned char` prevents this.


Diffs
-----

  3rdparty/stout/include/stout/version.hpp 9120e42eedcfb4fc5ee41f08354441bc10914baf 


Diff: https://reviews.apache.org/r/59110/diff/1/


Testing
-------

Build and ran `stout-tests` target on Windows. `make check` in `build/3rdparty/stout` on Linux.

```
[ RUN      ] VersionTest.ParseValid
[       OK ] VersionTest.ParseValid (0 ms)
```


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message