> On March 20, 2017, 1:32 p.m., Benjamin Mahler wrote:
> > Have you seen the feedback [here](https://issues.apache.org/jira/browse/MESOS-3465?focusedCommentId=14944383&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14944383)?
It would be nice to make it clear in the log that the program is exiting IMHO.
I think you meant https://issues.apache.org/jira/browse/MESOS-3465
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56681/#review169495
-----------------------------------------------------------
On May 8, 2017, 4:30 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56681/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 4:30 p.m.)
>
>
> Review request for mesos, haosdent huang and Jiang Yan Xu.
>
>
> Bugs: MESOS-7115
> https://issues.apache.org/jira/browse/MESOS-7115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use glog to log EXIT() messages.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/exit.hpp 762864afd8f86f7e1f439ef6ea7e3965a5f147d5
>
>
> Diff: https://reviews.apache.org/r/56681/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 25)
>
> **Example output after this change:**
> ```
> [jpeach@jpeach build]$ sudo ./src/mesos-agent --work_dir=/nothing/here --master=phoney:5050
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> I0320 11:01:10.362782 921 main.cpp:368] Build: 2017-03-20 10:43:40 by jpeach
> I0320 11:01:10.362900 921 main.cpp:369] Version: 1.3.0
> I0320 11:01:10.362912 921 main.cpp:376] Git SHA: b0d82241a886e9c6239ce82c5135c4c72c44aca7
> I0320 11:01:10.381340 921 systemd.cpp:238] systemd version `231` detected
> I0320 11:01:10.381404 921 main.cpp:478] Inializing systemd state
> I0320 11:01:10.390058 921 systemd.cpp:326] Started systemd slice `mesos_executors.slice`
> I0320 11:01:10.392071 921 containerizer.cpp:221] Using isolation: posix/cpu,posix/mem,filesystem/posix,network/cni
> I0320 11:01:10.401108 921 linux_launcher.cpp:150] Using /sys/fs/cgroup/freezer as the
freezer hierarchy for the Linux launcher
> I0320 11:01:10.402873 921 provisioner.cpp:249] Using default backend 'overlay'
> E0320 11:01:10.426219 921 main.cpp:507] Failed to create a master detector: Failed
to parse 'phoney:5050'
> ```
>
> **Example output before this change:**
> ```
> [jpeach@jpeach build]$ sudo /opt/mesos/sbin//mesos-agent --work_dir=/nothing/here --master=phoney:5050
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> I0320 11:03:43.868015 1188 main.cpp:243] Build: 2017-03-10 10:49:55 by jpeach
> I0320 11:03:43.868135 1188 main.cpp:244] Version: 1.3.0
> I0320 11:03:43.868151 1188 main.cpp:251] Git SHA: 487c667260ec89127e18c77b9e8c8c243cf6ec57
> I0320 11:03:43.886561 1188 systemd.cpp:238] systemd version `231` detected
> I0320 11:03:43.886631 1188 main.cpp:342] Inializing systemd state
> I0320 11:03:43.896606 1188 systemd.cpp:326] Started systemd slice `mesos_executors.slice`
> I0320 11:03:43.899202 1188 containerizer.cpp:221] Using isolation: posix/cpu,posix/mem,filesystem/posix,network/cni
> I0320 11:03:43.911183 1188 linux_launcher.cpp:150] Using /sys/fs/cgroup/freezer as the
freezer hierarchy for the Linux launcher
> I0320 11:03:43.913216 1188 provisioner.cpp:249] Using default backend 'overlay'
> Failed to create a master detector: Failed to parse 'phoney:5050'
> ```
>
>
> Thanks,
>
> James Peach
>
>
|