mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 58908: Updated test mocks per interface changes.
Date Mon, 08 May 2017 22:45:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58908/
-----------------------------------------------------------

(Updated May 8, 2017, 3:45 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Fixed how the test containerizer's two launch paths were combined.


Bugs: MESOS-7304 and MESOS-7449
    https://issues.apache.org/jira/browse/MESOS-7304
    https://issues.apache.org/jira/browse/MESOS-7449


Repository: mesos


Description
-------

This updates the mocks for the containerizers and fetcher after
the interface changes.  For the containerizers, the two launch methods
have been combined into a single method.

The fetcher now has an argument in its constructor and no longer
takes some arguments (SlaveID and Flags) in its methods.

Launching nested containers via the test containerizer was
originally a no-op, so similar behavior is implemented in the
combined method.


Diffs (updated)
-----

  src/tests/cluster.cpp a4f57e0e9c4f221c42bdbb36d8925f688b3d742f 
  src/tests/containerizer.hpp 63fe2366d5fe79c71cbe62813a9bb0b830e70057 
  src/tests/containerizer.cpp 548da3a8757c9ad3ab115c6b91f8a1f2f5e37144 
  src/tests/containerizer/mock_containerizer.hpp ca0ae053b1eed01d6c04f581cd08485beec0c5fb

  src/tests/mesos.hpp 3c57f25ff0bec55582b8a7decef53be61a9ec6f4 
  src/tests/mesos.cpp a79ec62d6b8354a97a50533dc66e04c1afc4bef6 
  src/tests/mock_docker.hpp f58211d93e3231bfef7afa9e495930a70aae9f2b 
  src/tests/mock_docker.cpp 81a14ca346f0fbe6458e03b06932e1ad00a4a238 


Diff: https://reviews.apache.org/r/58908/diff/2/

Changes: https://reviews.apache.org/r/58908/diff/1-2/


Testing
-------

See last patch in chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message