mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 58924: Updated containerizer for isolator task_environment merge.
Date Mon, 08 May 2017 15:37:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58924/#review174173
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/containerizer.cpp
Lines 1363 (patched)
<https://reviews.apache.org/r/58924/#comment247293>

    Let's also log the container id?
    ```
    LOG(WARNING) << "Overwriting environment variable '" << name << "' "
                 << "for container " << containerId;
    ```


- Jie Yu


On May 2, 2017, 5:28 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58924/
> -----------------------------------------------------------
> 
> (Updated May 2, 2017, 5:28 p.m.)
> 
> 
> Review request for mesos, Adam B, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-7429
>     https://issues.apache.org/jira/browse/MESOS-7429
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae

> 
> 
> Diff: https://reviews.apache.org/r/58924/diff/3/
> 
> 
> Testing
> -------
> 
> make check and functional testing on chain end.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message