mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 58923: Added new ContainerLaunchInfo task_environment.
Date Sun, 07 May 2017 05:36:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58923/#review174125
-----------------------------------------------------------




include/mesos/slave/containerizer.proto
Lines 165-167 (patched)
<https://reviews.apache.org/r/58923/#comment247222>

    This comment is not accurate. The `environment` is not always for executors. It can be
for nested containers (so task_group task inside an executor). So let's explain it as `The
environment set for the container.`
    
    And not necessary to mention the inheritance here.



include/mesos/slave/containerizer.proto
Lines 189-190 (patched)
<https://reviews.apache.org/r/58923/#comment247223>

    I would rephase it as `The environment for command tasks specific.`
    
    And add a `TODO` for deprecating this field once command task is deprecated.



include/mesos/slave/containerizer.proto
Lines 191 (patched)
<https://reviews.apache.org/r/58923/#comment247224>

    BTW, let's move this field to the last position since it is for command task specific
and will be deprecated.


- Gilbert Song


On May 5, 2017, 7:46 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58923/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 7:46 p.m.)
> 
> 
> Review request for mesos, Adam B, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-7429
>     https://issues.apache.org/jira/browse/MESOS-7429
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2 
> 
> 
> Diff: https://reviews.apache.org/r/58923/diff/2/
> 
> 
> Testing
> -------
> 
> make check and functional testing on chain end.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message