mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 58923: Added new ContainerLaunchInfo task_environment.
Date Sat, 06 May 2017 02:49:17 GMT


> On May 4, 2017, 2:04 a.m., Adam B wrote:
> > The terminology in this area of the code confuses me. Do we have a glossary for
the different executors, command tasks, etc. somewhere?

That is confusing indeed - will add this particular point to a JIRA touching this area. https://issues.apache.org/jira/browse/MESOS-7435


> On May 4, 2017, 2:04 a.m., Adam B wrote:
> > include/mesos/slave/containerizer.proto
> > Lines 166 (patched)
> > <https://reviews.apache.org/r/58923/diff/1/?file=1705951#file1705951line166>
> >
> >     +1, or just drop "already".
> >     And tell me which non-custom executors do decide to pass their environment on
to the tasks.
> >     
> >     Also, the "Additional environment" confuses me. What is it in addition to? The
new `task_environment`? Comment should explain the relationship.

I did refrain from listing the non-custom executors as this passing-on should be true for
all of them.


> On May 4, 2017, 2:04 a.m., Adam B wrote:
> > include/mesos/slave/containerizer.proto
> > Lines 180-184 (original), 184-191 (patched)
> > <https://reviews.apache.org/r/58923/diff/1/?file=1705951#file1705951line184>
> >
> >     What's the difference between a `task command` and a `command task`?

It should have been "command task".


> On May 4, 2017, 2:04 a.m., Adam B wrote:
> > include/mesos/slave/containerizer.proto
> > Lines 192 (patched)
> > <https://reviews.apache.org/r/58923/diff/1/?file=1705951#file1705951line192>
> >
> >     What order did you insert this in? I'd say either go numeric and put it at the
end, or put it next to `environment` so you can explain the difference.

I deducted the current ordering was mostly based on the ordering of things when launching
a task -- pre_exec_commands come first, pre/executor things come next, task specifics last.
I put it below `command` as it strongly belongs to the task and the environment that may come
with `command` (`CommandInfo`) itself.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58923/#review173859
-----------------------------------------------------------


On May 6, 2017, 2:46 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58923/
> -----------------------------------------------------------
> 
> (Updated May 6, 2017, 2:46 a.m.)
> 
> 
> Review request for mesos, Adam B, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-7429
>     https://issues.apache.org/jira/browse/MESOS-7429
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2 
> 
> 
> Diff: https://reviews.apache.org/r/58923/diff/2/
> 
> 
> Testing
> -------
> 
> make check and functional testing on chain end.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message