mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 59010: Updated protobuf comments for Image::Secret.
Date Fri, 05 May 2017 15:16:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59010/#review174027
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/mesos.proto
Line 2140 (original), 2140 (patched)
<https://reviews.apache.org/r/59010/#comment247129>

    This field has never been...



include/mesos/v1/mesos.proto
Line 2134 (original), 2134 (patched)
<https://reviews.apache.org/r/59010/#comment247130>

    Same here.


- Chun-Hung Hsiao


On May 4, 2017, 11:22 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59010/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 11:22 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff,
and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated protobuf comments for Image::Secret.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 1935f47a52840f6b395ecb2d28296666551fa691 
>   include/mesos/v1/mesos.proto c7f0bec5c96f2f41344d4261d0696f9fe0421db7 
> 
> 
> Diff: https://reviews.apache.org/r/59010/diff/1/
> 
> 
> Testing
> -------
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message