mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 58999: Added --secret_resolver flag to agent.
Date Fri, 05 May 2017 10:41:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58999/
-----------------------------------------------------------

(Updated May 5, 2017, 6:41 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
-------

SecretFetcher -> SecretResolver; Option<SecretFetcher*> -> SecretResolver*


Summary (updated)
-----------------

Added --secret_resolver flag to agent.


Repository: mesos


Description (updated)
-------

Updated Containerizer to accept SecretResolver.


Diffs (updated)
-----

  src/local/local.cpp e47980929db2da1f31cf899a0e1fc452070e11f3 
  src/slave/containerizer/containerizer.hpp 4c31a1f5c853c1dc66480c7b4c867a87a1bb5c41 
  src/slave/containerizer/containerizer.cpp 9024371b6c4228f0903cfeef3bbec736e1a425f8 
  src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d

  src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae

  src/slave/flags.hpp c7a4604ed994e15c1db6accfaded2e882f1aec94 
  src/slave/flags.cpp c50e43c0e0ba633f6b905b0d78668c0a0eebb173 
  src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52 
  src/tests/containerizer/docker_volume_isolator_tests.cpp b47a6b5081a63ac474ac4634701b1a572eb58137

  src/tests/containerizer/mesos_containerizer_tests.cpp 13e0f7e603a3ffdd0965b253d7abfe6a069cd2b4



Diff: https://reviews.apache.org/r/58999/diff/2/

Changes: https://reviews.apache.org/r/58999/diff/1-2/


Testing
-------


Thanks,

Kapil Arya


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message