mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@apache.org>
Subject Re: Review Request 58998: Fixed extra newline in webui for re-registered frameworks.
Date Fri, 05 May 2017 02:16:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58998/#review173992
-----------------------------------------------------------




src/webui/master/static/framework.html
Lines 40-41 (original), 40-41 (patched)
<https://reviews.apache.org/r/58998/#comment247089>

    I think change `ng-show` to `ng-if` should be enough.
    
    ```
    <dd ng-if="!framework.reregistered_time">-</dd>
    <dd ng-if="framework.reregistered_time">
    ...
    ```


- haosdent huang


On May 4, 2017, 7:04 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58998/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 7:04 p.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed extra newline in webui for re-registered frameworks.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/framework.html 79dd1a7fa8c41c1e09141c273cc5d2e261e578b3 
> 
> 
> Diff: https://reviews.apache.org/r/58998/diff/1/
> 
> 
> Testing
> -------
> 
> Visual inspection.
> 
> Screenshot before: http://www.neilconway.org/tmp/screenshot_before.png
> 
> Screenshot after: http://www.neilconway.org/tmp/screenshot_after.png
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message