> On May 4, 2017, 6:25 p.m., Jie Yu wrote:
> > include/mesos/secret/fetcher.hpp
> > Lines 17 (patched)
> > <https://reviews.apache.org/r/58759/diff/3/?file=1708762#file1708762line17>
> >
> > I'd put the file to include/mesos/fetcher/secret_fetcher.hpp
I am not sure so sure about it because there is nothing in common between `Fetcher` and `SecretFetcher`.
One can think of `SecretFetcher` as more like secret-resolver.
Perhaps, next to authentication/secret_generator.hpp would be slightly better, but then it
doesn't have much to do with authentication either.
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review173966
-----------------------------------------------------------
On May 4, 2017, 4:06 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 4:06 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduced SecretFetcher module interface.
>
>
> Diffs
> -----
>
> include/mesos/module/secretfetcher.hpp PRE-CREATION
> include/mesos/secret/fetcher.hpp PRE-CREATION
> src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4
> src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193
>
>
> Diff: https://reviews.apache.org/r/58759/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
|