-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review173966
-----------------------------------------------------------
include/mesos/module/secretfetcher.hpp
Lines 17 (patched)
<https://reviews.apache.org/r/58759/#comment247059>
secret_fetcher.hpp
(we have secret_generator.hpp). Let's make sure it's consistent.
include/mesos/secret/fetcher.hpp
Lines 17 (patched)
<https://reviews.apache.org/r/58759/#comment247060>
I'd put the file to include/mesos/fetcher/secret_fetcher.hpp
- Jie Yu
On May 4, 2017, 8:06 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 8:06 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduced SecretFetcher module interface.
>
>
> Diffs
> -----
>
> include/mesos/module/secretfetcher.hpp PRE-CREATION
> include/mesos/secret/fetcher.hpp PRE-CREATION
> src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4
> src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193
>
>
> Diff: https://reviews.apache.org/r/58759/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
|