mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Review Request 59000: Added environment secret isolator.
Date Thu, 04 May 2017 20:08:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59000/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, and Vinod Kone.


Repository: mesos


Description
-------

This isolator resolves Secret-type environment variables using a provided SecretFetcher module.


Diffs
-----

  src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
  src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4 
  src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae

  src/slave/containerizer/mesos/isolators/environment_secret.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/environment_secret.cpp PRE-CREATION 
  src/tests/containerizer/environment_secret_isolator_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/59000/diff/1/


Testing
-------

Added a new test and ran `make check`.


Thanks,

Kapil Arya


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message