mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 58974: Fixed flakiness in HierarchicalAllocatorTest.NestedRoleQuota.
Date Thu, 04 May 2017 08:55:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58974/#review173883
-----------------------------------------------------------



Patch looks great!

Reviews applied: [58974]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 3, 2017, 8:46 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58974/
> -----------------------------------------------------------
> 
> (Updated May 3, 2017, 8:46 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7457
>     https://issues.apache.org/jira/browse/MESOS-7457
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed flakiness in HierarchicalAllocatorTest.NestedRoleQuota.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp ebc4868a6b7e2a04cc202a74a4633969ade40aca

> 
> 
> Diff: https://reviews.apache.org/r/58974/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> I wasn't able to repro the flakiness on my local box, but the previous test coding does
seem wrong, now that `setQuota` doesn't trigger a batch allocation.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message