mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 58953: WIP: Added transitional allocator overloads.
Date Thu, 04 May 2017 02:04:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58953/#review173860
-----------------------------------------------------------



Patch looks great!

Reviews applied: [57911, 57997, 57998, 57999, 58048, 58047, 58021, 58071, 58072, 58949, 58950,
58951, 58952, 58953]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 3, 2017, 12:08 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58953/
> -----------------------------------------------------------
> 
> (Updated May 3, 2017, 12:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-7388
>     https://issues.apache.org/jira/browse/MESOS-7388
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commits adds allocator overloads working with resource providers
> instead of agents which currently are assumed to be called with agent
> resource providers. This is so that users of the allocator can
> transition to the overloads taking resource providers.
> 
> In a subsequent commit the allocator overloads directly taking agent
> variables will be removed in favor of the ones taking resource
> providers; at the same time all methods in the allocator interface
> will be made virtual again in order to call specific derived
> implementation methods.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp dc34a1b6f0c2bdf0d653bd53394364cfa9873ca7 
> 
> 
> Diff: https://reviews.apache.org/r/58953/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message