mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 58310: Removed workaround for lack of `thread_local` on OS X.
Date Wed, 03 May 2017 21:18:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58310/#review173828
-----------------------------------------------------------


Ship it!




Ship It!

- Anand Mazumdar


On April 10, 2017, 8:06 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58310/
> -----------------------------------------------------------
> 
> (Updated April 10, 2017, 8:06 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: MESOS-7373
>     https://issues.apache.org/jira/browse/MESOS-7373
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Until XCode 8, Apple's build toolchain did not support the
> `thread_local` feature from C++11. Hence, Stout provided a
> `THREAD_LOCAL` macro, which expanded to `__thread` on OS X and
> `thread_local` on other platforms.
> 
> XCode 8 added support for `thread_local`, so we can remove this
> workaround. Note that XCode 8 requires OS X 10.11.5 or newer.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/thread_local.hpp 7ffc809c720abe477fb92851d530ae49dcb23f49

> 
> 
> Diff: https://reviews.apache.org/r/58310/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on OSX with XCode 8, internal CI build, `make check` on CentOS 6.6
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message