mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 58974: Fixed flakiness in HierarchicalAllocatorTest.NestedRoleQuota.
Date Wed, 03 May 2017 20:46:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58974/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-7457
    https://issues.apache.org/jira/browse/MESOS-7457


Repository: mesos


Description
-------

Fixed flakiness in HierarchicalAllocatorTest.NestedRoleQuota.


Diffs
-----

  src/tests/hierarchical_allocator_tests.cpp ebc4868a6b7e2a04cc202a74a4633969ade40aca 


Diff: https://reviews.apache.org/r/58974/diff/1/


Testing
-------

`make check`

I wasn't able to repro the flakiness on my local box, but the previous test coding does seem
wrong, now that `setQuota` doesn't trigger a batch allocation.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message