-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58874/#review173801
-----------------------------------------------------------
src/webui/master/static/browse.html
Lines 15-16 (original), 15-16 (patched)
<https://reviews.apache.org/r/58874/#comment246836>
Looking at the gif, it seems the slashes weren't copied before? Do you want to clarify
that here? Specifically, it seems this also ensures the slashes are being copied?
src/webui/master/static/css/mesos.css
Lines 179-181 (patched)
<https://reviews.apache.org/r/58874/#comment246837>
Can you add a comment on what this does and when one would need to use it?
- Benjamin Mahler
On May 3, 2017, 4:29 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58874/
> -----------------------------------------------------------
>
> (Updated May 3, 2017, 4:29 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stripped spaces between directory elements in WebUI.
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html b9849197227b06df348789a49348e2b5d4cfd2ae
> src/webui/master/static/css/mesos.css 9f3de5427071fc61d3791c4bc2a660368c2cd3c2
>
>
> Diff: https://reviews.apache.org/r/58874/diff/2/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> strip_space.gif
> https://reviews.apache.org/media/uploaded/files/2017/05/03/79afd0b1-5fb1-437c-a91c-732009af8fe3__strip_space.gif
>
>
> Thanks,
>
> haosdent huang
>
>
|