mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 58950: WIP: Made persistent volume endpoints tests independent from allocator.
Date Wed, 03 May 2017 12:08:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58950/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Bugs: MESOS-7388
    https://issues.apache.org/jira/browse/MESOS-7388


Repository: mesos


Description
-------

The tests in the case often require an agent ID. To obtain the ID they
were using a mock allocator to grab agent ID, but not other operations
with the allocator were performed.

Instead we now just capture the SlaveRegisteredMessage in order to
learn an agent's ID.


Diffs
-----

  src/tests/persistent_volume_endpoints_tests.cpp 1237d081d781948975f66a8240ae9bdb5e819a3b



Diff: https://reviews.apache.org/r/58950/diff/1/


Testing
-------

`make check`, also in repetition.

While this patch is part of this series since later patches depend on it, it could be commited
independently.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message