mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Janiszewski <jani...@gmail.com>
Subject Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.
Date Wed, 03 May 2017 09:59:44 GMT


> On Maj 1, 2017, 8:45 po poĊ‚udniu, Tomasz Janiszewski wrote:
> > src/webui/master/static/js/controllers.js
> > Lines 1024 (patched)
> > <https://reviews.apache.org/r/58872/diff/1/?file=1703827#file1703827line1024>
> >
> >     It's not obious why we remove update listener on route change start. Can you
add a comment with clarification?
> 
> haosdent huang wrote:
>     It is because we no need to call this again if route change, so we remove it here.
We do it in almost places which depends on `$scope.state`.
>     
>     ```
>         var removeListener = $scope.$on('state_updated', update);
>         $scope.$on('$routeChangeStart', removeListener);
>     ```
>     
>     Do you think we need to add comment about this here?

No that's fine. Just spoted it's a template.


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58872/#review173504
-----------------------------------------------------------


On Maj 3, 2017, 4:15 rano, haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58872/
> -----------------------------------------------------------
> 
> (Updated Maj 3, 2017, 4:15 rano)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Bugs: MESOS-4992
>     https://issues.apache.org/jira/browse/MESOS-4992
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Open sandbox link in a new tab would fail since it depends on agents
> information loading finish. This patch fixes it by ensuring the agents
> information loaded first and then rerouting the sandbox request.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js a021962573d452de1581e6a7717016eac7d0cd85

> 
> 
> Diff: https://reviews.apache.org/r/58872/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message