mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Janiszewski <jani...@gmail.com>
Subject Re: Review Request 58874: Stripped spaces between directory elements in WebUI.
Date Wed, 03 May 2017 09:54:19 GMT


> On Maj 1, 2017, 8:14 po południu, Tomasz Janiszewski wrote:
> > src/webui/master/static/browse.html
> > Line 17 (original), 17 (patched)
> > <https://reviews.apache.org/r/58874/diff/1/?file=1703836#file1703836line17>
> >
> >     Could you keep original formatting?
> 
> haosdent huang wrote:
>     Change to
>     
>     ```
>       <li ng-repeat="dir in path.split('/')"><a
>           href="#/agents/{{agent_id}}/browse?path={{
>                 encodeURIComponent(path.split('/').slice(0, $index + 1).join('/'))
>                 }}">{{dir}}</a><span class="copy-placeholder">/</span></li>
>     ```
>     
>     Is it match you expection here?

That's OK. We must keep everything in one line to prevent newlines and spaces to appear.


> On Maj 1, 2017, 8:14 po południu, Tomasz Janiszewski wrote:
> > src/webui/master/static/css/mesos.css
> > Lines 180 (patched)
> > <https://reviews.apache.org/r/58874/diff/1/?file=1703837#file1703837line180>
> >
> >     I think this should be replaced with `visibility: hidden;`. With `font-size:
0;` there is different (smaller) padding then before the change.
> 
> haosdent huang wrote:
>     Oh, I didn't use it because with `visibility: hidden`, the copy content would not
include `` in my browser. Is it work in your side?

My mistake, I'm sorry.


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58874/#review173499
-----------------------------------------------------------


On Maj 3, 2017, 4:29 rano, haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58874/
> -----------------------------------------------------------
> 
> (Updated Maj 3, 2017, 4:29 rano)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stripped spaces between directory elements in WebUI.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/browse.html b9849197227b06df348789a49348e2b5d4cfd2ae 
>   src/webui/master/static/css/mesos.css 9f3de5427071fc61d3791c4bc2a660368c2cd3c2 
> 
> 
> Diff: https://reviews.apache.org/r/58874/diff/2/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> strip_space.gif
>   https://reviews.apache.org/media/uploaded/files/2017/05/03/79afd0b1-5fb1-437c-a91c-732009af8fe3__strip_space.gif
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message