mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@apache.org>
Subject Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.
Date Wed, 03 May 2017 04:18:16 GMT


> On May 1, 2017, 8:45 p.m., Tomasz Janiszewski wrote:
> > src/webui/master/static/js/controllers.js
> > Lines 1019 (patched)
> > <https://reviews.apache.org/r/58872/diff/1/?file=1703827#file1703827line1019>
> >
> >     Please add a comment for this condition with information why it can happen.
The comment could be the same as previously used:
> >     
> >     > When navigating directly to this page, e.g. pasting the URL into the browser

Thank you very much, have updated.


> On May 1, 2017, 8:45 p.m., Tomasz Janiszewski wrote:
> > src/webui/master/static/js/controllers.js
> > Lines 1024 (patched)
> > <https://reviews.apache.org/r/58872/diff/1/?file=1703827#file1703827line1024>
> >
> >     It's not obious why we remove update listener on route change start. Can you
add a comment with clarification?

It is because we no need to call this again if route change, so we remove it here. We do it
in almost places which depends on `$scope.state`.

```
    var removeListener = $scope.$on('state_updated', update);
    $scope.$on('$routeChangeStart', removeListener);
```

Do you think we need to add comment about this here?


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58872/#review173504
-----------------------------------------------------------


On May 3, 2017, 4:15 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58872/
> -----------------------------------------------------------
> 
> (Updated May 3, 2017, 4:15 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Bugs: MESOS-4992
>     https://issues.apache.org/jira/browse/MESOS-4992
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Open sandbox link in a new tab would fail since it depends on agents
> information loading finish. This patch fixes it by ensuring the agents
> information loaded first and then rerouting the sandbox request.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js a021962573d452de1581e6a7717016eac7d0cd85

> 
> 
> Diff: https://reviews.apache.org/r/58872/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message