mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Review Request 58939: Filesystem isolation check for Mesos containerizer under Linux.
Date Tue, 02 May 2017 23:59:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58939/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.


Bugs: mesos-7374
    https://issues.apache.org/jira/browse/mesos-7374


Repository: mesos


Description
-------

Checked if the 'filesystem/linux' isolator is active when launching a
mesos containerizer with an image under Linux. This prevents the
executor from messing up with the host filesystem when launching nested
containers with failures.

The check is placed in `MesosContainerizerProcess::prepare()`, which is
executed after provisioning but before launching, since the isolator is
not required for the provisioner, so the existing unit tests for
provisioners won't fail.


Diffs
-----

  src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae

  src/slave/containerizer/mesos/provisioner/provisioner.cpp be45fc59027f176b43b767e9441fd8089ceec7b4



Diff: https://reviews.apache.org/r/58939/diff/1/


Testing
-------

sudo make check
Manual tested a simplified case of mesos-7374.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message