mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 58137: CLI: Added 'mesos config show' command to display the config file.
Date Tue, 02 May 2017 23:16:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/#review173675
-----------------------------------------------------------




src/cli_new/lib/cli/plugins/config/main.py
Lines 87 (patched)
<https://reviews.apache.org/r/58137/#comment246703>

    We shoud use the syntax where we name the placeholder instead of leaving it anonymous,
i.e.:
    ```
    sys.stdout.write("{stream}\n".format(stream=stream.read().rstrip()))
    ```


- Kevin Klues


On April 12, 2017, 9:21 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58137/
> -----------------------------------------------------------
> 
> (Updated April 12, 2017, 9:21 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This command displays the contents of the user-defined config.toml file.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7

> 
> 
> Diff: https://reviews.apache.org/r/58137/diff/6/
> 
> 
> Testing
> -------
> 
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message