mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 58394: Setup new directory for python http client lib in src/python.
Date Tue, 02 May 2017 23:11:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58394/#review173674
-----------------------------------------------------------




src/python/.gitignore
Lines 1 (patched)
<https://reviews.apache.org/r/58394/#comment246700>

    Why do you need .virtualenv in this folder? I wouldn't expect us to create a .virtualenv
directory anywhere within this subolder (at least not yet). Once we move the cli code under
this folder it might make sense. But not yet.



src/python/lib/mesos/__init__.py
Lines 1 (patched)
<https://reviews.apache.org/r/58394/#comment246699>

    I would exclude this from this commit.
    It is not used anywhere, therefore it should not be included until the commit where it
is used.


- Kevin Klues


On April 12, 2017, 9:44 p.m., Eric Chung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58394/
> -----------------------------------------------------------
> 
> (Updated April 12, 2017, 9:44 p.m.)
> 
> 
> Review request for mesos, Jason Lai, Joseph Wu, and Kevin Klues.
> 
> 
> Bugs: MESOS-7310
>     https://issues.apache.org/jira/browse/MESOS-7310
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Setup new directory for python http client lib in src/python.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/bootstrap 6d62e9adf1d543ed00a3a2cf2484edf1c33ee443 
>   src/python/.gitignore PRE-CREATION 
>   src/python/lib/mesos/__init__.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58394/diff/1/
> 
> 
> Testing
> -------
> 
> Under src/cli_new:
> 1\. ./bootstrap
> 2\. . ./activate
> 3\. python
> 4\. >>> import mesos
> 5\. >>> mesos.\_\_path\_\_
> 6\. verify that the path printed out is indeed at src/python/lib/mesos
> 
> 
> Thanks,
> 
> Eric Chung
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message