mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 58916: Fixed a minor bug in setting the agent's `totalResources`.
Date Tue, 02 May 2017 15:40:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58916/#review173597
-----------------------------------------------------------


Ship it!




Ship It!

- Jiang Yan Xu


On May 2, 2017, 1:26 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58916/
> -----------------------------------------------------------
> 
> (Updated May 2, 2017, 1:26 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If the following branch is taken, `totalResources` would be set
> to `resources.get()` which is not equal to `info.resources()`.
> 
> ```cpp
>   if (HookManager::hooksAvailable()) {
>     info.mutable_resources()->CopyFrom(
>         HookManager::slaveResourcesDecorator(info));
>   }
> ```
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 8b8078dbb656e9db2efa53cc4ec5bed2cc01d49a 
> 
> 
> Diff: https://reviews.apache.org/r/58916/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message