mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 58587: Clarified comments about resource operations through operator API.
Date Tue, 02 May 2017 07:13:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58587/#review173561
-----------------------------------------------------------




src/master/http.cpp
Lines 4870-4872 (patched)
<https://reviews.apache.org/r/58587/#comment246558>

    Thanks for adding this! This is the issue that I was considering filing a JIRA ticket
for.



src/master/http.cpp
Lines 4884-4889 (patched)
<https://reviews.apache.org/r/58587/#comment246557>

    I'm not quite following this example. Specifically, I don't get what "a persistent volume
can be destroyed if it is not allocated" means..


- Michael Park


On May 1, 2017, 2:29 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58587/
> -----------------------------------------------------------
> 
> (Updated May 1, 2017, 2:29 p.m.)
> 
> 
> Review request for mesos, Anindya Sinha and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Seems like the comments about "virtually always win the race against
> 'allocate'" could be made more precise in helping people understand
> how it works.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 5aae52870451d883ef1ea1fda5a27764d7f318e8 
> 
> 
> Diff: https://reviews.apache.org/r/58587/diff/1/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message