mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 58906: Removed extranous sandbox initialization in Docker containerizer.
Date Tue, 02 May 2017 02:06:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58906/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-7449
    https://issues.apache.org/jira/browse/MESOS-7449


Repository: mesos


Description
-------

The Docker containerizer will create a stdout/stderr file as well
`chown` the sandbox directory to the user specified at container
creation time.  This logic is already performed elsewhere.

The stdout/stderr files will either be created prior to the container
launch via the mesos-fetcher, or during launch via the ContainerLogger.

The sandbox directory will be `chown`d by the Agent when it
starts to launch the executor.


Diffs
-----

  src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7 


Diff: https://reviews.apache.org/r/58906/diff/1/


Testing
-------

See last patch in chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message