mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 58709: Prevent old Mesos agents from registering or re-registering.
Date Mon, 01 May 2017 23:45:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58709/
-----------------------------------------------------------

(Updated May 1, 2017, 11:45 p.m.)


Review request for mesos, Benjamin Mahler and Kapil Arya.


Changes
-------

Address review comments.


Bugs: MESOS-6976
    https://issues.apache.org/jira/browse/MESOS-6976


Repository: mesos


Description
-------

Officially, Mesos 1.0.0 (and newer) masters do not support pre-1.0.0
Mesos agents. However, we previously allowed old agents to register,
which resulted in several master crashes. As a short-term solution, we
fixed those crashes by adding backward compatibility mechanisms into the
master, but that backward compatibility code has made the master logic
more complicated and difficult to understand.

This commit changes the master to ignore registration attempts by Mesos
agents that precede Mesos 1.0.0. Now that this safety check is in place,
master logic can safely assume that all agents are running at least
Mesos 1.0.0, which will allow several simplifications to be made.


Diffs (updated)
-----

  src/master/constants.hpp 7edf9f65f6615b67ad0663f75ea7ee72a6a558cb 
  src/master/master.cpp 31a7a2fcf905c0c35e80692a69c290d4094deded 
  src/tests/master_tests.cpp 7cb4774fae1feff007adacf6521fadde2f58bee7 


Diff: https://reviews.apache.org/r/58709/diff/2/

Changes: https://reviews.apache.org/r/58709/diff/1-2/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message