mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.
Date Mon, 01 May 2017 22:45:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58872/#review173525
-----------------------------------------------------------



Thanks for tackling this!


src/webui/master/static/js/controllers.js
Lines 906 (patched)
<https://reviews.apache.org/r/58872/#comment246512>

    Should this be called "update"? It looks to me like it's responsible for redirecting.
    
    Also, like Tomasz pointed out, I can't really tell what the if condition below does to
fix the problem. Would you mind spelling out the problem and the fix in the description?


- Benjamin Mahler


On April 29, 2017, 6:22 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58872/
> -----------------------------------------------------------
> 
> (Updated April 29, 2017, 6:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Bugs: MESOS-4992
>     https://issues.apache.org/jira/browse/MESOS-4992
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensured sandbox URI request reroute after fetched `$scope.state`.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js a021962573d452de1581e6a7717016eac7d0cd85

> 
> 
> Diff: https://reviews.apache.org/r/58872/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message