mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 57964: Added a test to verify metrics when shared resources are present.
Date Mon, 01 May 2017 22:33:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57964/#review173522
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/persistent_volume_tests.cpp
Lines 1175 (patched)
<https://reviews.apache.org/r/57964/#comment246511>

    s/use shared persistent volumes to launch/can use the same shared persistent volume to
launch/ 
    
    This pairs with the word `verifies`?
    
    In the next sentence, s/It verifies/It also verifies/ ?


- Jiang Yan Xu


On April 22, 2017, 10 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57964/
> -----------------------------------------------------------
> 
> (Updated April 22, 2017, 10 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7186
>     https://issues.apache.org/jira/browse/MESOS-7186
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test to verify metrics when shared resources are present.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 3eb7afe3de8e72ffb6502dfe12ef37ccd4ca2125 
> 
> 
> Diff: https://reviews.apache.org/r/57964/diff/3/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message