mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Janiszewski <jani...@gmail.com>
Subject Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.
Date Mon, 01 May 2017 20:45:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58872/#review173504
-----------------------------------------------------------


Fix it, then Ship it!




I tested it and it fixes the issue. I think code need some comments, it's simple but not obvious.


src/webui/master/static/js/controllers.js
Lines 1019 (patched)
<https://reviews.apache.org/r/58872/#comment246494>

    Please add a comment for this condition with information why it can happen. The comment
could be the same as previously used:
    
    > When navigating directly to this page, e.g. pasting the URL into the browser



src/webui/master/static/js/controllers.js
Lines 1024 (patched)
<https://reviews.apache.org/r/58872/#comment246496>

    It's not obious why we remove update listener on route change start. Can you add a comment
with clarification?


- Tomasz Janiszewski


On Kwi 29, 2017, 6:22 po południu, haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58872/
> -----------------------------------------------------------
> 
> (Updated Kwi 29, 2017, 6:22 po południu)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Bugs: MESOS-4992
>     https://issues.apache.org/jira/browse/MESOS-4992
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensured sandbox URI request reroute after fetched `$scope.state`.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js a021962573d452de1581e6a7717016eac7d0cd85

> 
> 
> Diff: https://reviews.apache.org/r/58872/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message