mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 58766: Fixed coding style issues in ProvisionerDockerBackendTest.
Date Mon, 01 May 2017 20:37:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58766/#review173507
-----------------------------------------------------------



Patch looks great!

Reviews applied: [58764, 58766]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 1, 2017, 6:14 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58766/
> -----------------------------------------------------------
> 
> (Updated May 1, 2017, 6:14 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced a string concatenation with path::join() and
> a shell echo command with os::write() in
> ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_Overwrite.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 52e57cef81f79ebae4d5305708929396c5d75680

> 
> 
> Diff: https://reviews.apache.org/r/58766/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message