mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Janiszewski <jani...@gmail.com>
Subject Re: Review Request 58874: Stripped spaces between directory elements in WebUI.
Date Mon, 01 May 2017 20:14:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58874/#review173499
-----------------------------------------------------------


Fix it, then Ship it!




Nice usability improvement.


src/webui/master/static/browse.html
Line 17 (original), 17 (patched)
<https://reviews.apache.org/r/58874/#comment246488>

    Could you keep original formatting?



src/webui/master/static/css/mesos.css
Lines 180 (patched)
<https://reviews.apache.org/r/58874/#comment246487>

    I think this should be replaced with `visibility: hidden;`. With `font-size: 0;` there
is different (smaller) padding then before the change.


- Tomasz Janiszewski


On Kwi 30, 2017, 4:29 rano, haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58874/
> -----------------------------------------------------------
> 
> (Updated Kwi 30, 2017, 4:29 rano)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stripped spaces between directory elements in WebUI.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/browse.html b9849197227b06df348789a49348e2b5d4cfd2ae 
>   src/webui/master/static/css/mesos.css 9f3de5427071fc61d3791c4bc2a660368c2cd3c2 
> 
> 
> Diff: https://reviews.apache.org/r/58874/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message