mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 58766: Fixed coding style issues in ProvisionerDockerBackendTest.
Date Mon, 01 May 2017 18:14:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58766/
-----------------------------------------------------------

(Updated May 1, 2017, 6:14 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Neil Conway.


Changes
-------

Addressed Jie's comment.


Summary (updated)
-----------------

Fixed coding style issues in ProvisionerDockerBackendTest.


Repository: mesos


Description (updated)
-------

Replaced a string concatenation with path::join() and
a shell echo command with os::write() in
ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_Overwrite.


Diffs (updated)
-----

  src/tests/containerizer/provisioner_docker_tests.cpp 52e57cef81f79ebae4d5305708929396c5d75680



Diff: https://reviews.apache.org/r/58766/diff/2/

Changes: https://reviews.apache.org/r/58766/diff/1-2/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message