From reviews-return-59830-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Apr 29 04:18:51 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DF6EC19A0C for ; Sat, 29 Apr 2017 04:18:51 +0000 (UTC) Received: (qmail 27018 invoked by uid 500); 29 Apr 2017 04:18:51 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 26932 invoked by uid 500); 29 Apr 2017 04:18:49 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 26921 invoked by uid 99); 29 Apr 2017 04:18:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Apr 2017 04:18:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 616F0C0537; Sat, 29 Apr 2017 04:18:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id XVyX5UXWv12h; Sat, 29 Apr 2017 04:18:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B4A715FBB9; Sat, 29 Apr 2017 04:18:46 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2305CE0051; Sat, 29 Apr 2017 04:18:46 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B7109C4005C; Sat, 29 Apr 2017 04:18:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6405219715214562046==" MIME-Version: 1.0 Subject: Re: Review Request 58763: Added volume/secret isolator. From: Mesos Reviewbot To: Jie Yu , Vinod Kone , Gilbert Song Cc: Kapil Arya , Mesos Reviewbot , mesos Date: Sat, 29 Apr 2017 04:18:45 -0000 Message-ID: <20170429041845.16779.96391@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58763/ X-Sender: Mesos Reviewbot References: <20170428185411.16780.94979@reviews-vm2.apache.org> In-Reply-To: <20170428185411.16780.94979@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/secret.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/secret.hpp Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============6405219715214562046== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58763/#review173416 ----------------------------------------------------------- Patch looks great! Reviews applied: [58758, 58759, 58760, 58761, 58762, 58763] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 28, 2017, 6:54 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58763/ > ----------------------------------------------------------- > > (Updated April 28, 2017, 6:54 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7418 > https://issues.apache.org/jira/browse/MESOS-7418 > > > Repository: mesos > > > Description > ------- > > This is still Work in Progress. > > > Diffs > ----- > > src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 > src/slave/containerizer/containerizer.hpp 4c31a1f5c853c1dc66480c7b4c867a87a1bb5c41 > src/slave/containerizer/containerizer.cpp 9024371b6c4228f0903cfeef3bbec736e1a425f8 > src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d > src/slave/containerizer/mesos/containerizer.cpp 56db7eb1193c9812b62b9149c9c2b2dd9b66701c > src/slave/containerizer/mesos/isolators/volume/secret.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/secret.cpp PRE-CREATION > src/tests/cluster.hpp 65634121b7fe076a7cd9a1c5aa6101a96b1c009d > src/tests/cluster.cpp a4f57e0e9c4f221c42bdbb36d8925f688b3d742f > src/tests/mock_slave.hpp 767ed3d0444258f30b7338981ccc0080166ac5a7 > src/tests/mock_slave.cpp c435ec76ac44775bf8a87421640649495c16187e > > > Diff: https://reviews.apache.org/r/58763/diff/1/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > > --===============6405219715214562046==--