From reviews-return-59810-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 28 19:17:10 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 06A6319846 for ; Fri, 28 Apr 2017 19:17:10 +0000 (UTC) Received: (qmail 75228 invoked by uid 500); 28 Apr 2017 19:17:09 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 75192 invoked by uid 500); 28 Apr 2017 19:17:09 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 75176 invoked by uid 99); 28 Apr 2017 19:17:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Apr 2017 19:17:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 343A8189645; Fri, 28 Apr 2017 19:17:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.451 X-Spam-Level: **** X-Spam-Status: No, score=4.451 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 2CMrLDuwhocN; Fri, 28 Apr 2017 19:17:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2A9835F1BA; Fri, 28 Apr 2017 19:17:08 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C9C5FE06BB; Fri, 28 Apr 2017 19:17:07 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 89092C40042; Fri, 28 Apr 2017 19:17:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6885436140736303185==" MIME-Version: 1.0 Subject: Re: Review Request 58847: Checkpointed and recovered ContainerLaunchInfo for non-orphans. From: Vinod Kone To: =?utf-8?q?Gast=C3=B3n_Kleiman?= , Vinod Kone , Jie Yu Cc: Alexander Rukletsov , mesos Date: Fri, 28 Apr 2017 19:17:07 -0000 Message-ID: <20170428191707.16780.12750@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58847/ X-Sender: Vinod Kone X-ReviewBoard-ShipIt: 1 References: <20170428161431.16780.2536@reviews-vm2.apache.org> In-Reply-To: <20170428161431.16780.2536@reviews-vm2.apache.org> Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============6885436140736303185== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58847/#review173368 ----------------------------------------------------------- Ship it! LGTM modulo Jie's comments. - Vinod Kone On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58847/ > ----------------------------------------------------------- > > (Updated April 28, 2017, 4:14 p.m.) > > > Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > In mesos containerizer, cache each container's launch info and > recover it for non-orphan containers. This is a prerequisite for > persisting some container characteristics across agent failover. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae > src/slave/containerizer/mesos/paths.hpp d85fd34660faacd9c73de2ba7b87b3bbd4b6007b > src/slave/containerizer/mesos/paths.cpp ed4bbd2491e71ad1e4a41e0575b514377d02da9b > > > Diff: https://reviews.apache.org/r/58847/diff/1/ > > > Testing > ------- > > See https://reviews.apache.org/r/58718/ > > > Thanks, > > Alexander Rukletsov > > --===============6885436140736303185==--