From reviews-return-59806-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 28 18:50:51 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3A26D196C6 for ; Fri, 28 Apr 2017 18:50:51 +0000 (UTC) Received: (qmail 8871 invoked by uid 500); 28 Apr 2017 18:50:51 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 8840 invoked by uid 500); 28 Apr 2017 18:50:51 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 8829 invoked by uid 99); 28 Apr 2017 18:50:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Apr 2017 18:50:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 783E8C0255; Fri, 28 Apr 2017 18:50:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id EISP60YJOHeh; Fri, 28 Apr 2017 18:50:49 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5832D5F642; Fri, 28 Apr 2017 18:50:49 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E7C50E00B4; Fri, 28 Apr 2017 18:50:48 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D9629C40042; Fri, 28 Apr 2017 18:50:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0775761638376213033==" MIME-Version: 1.0 Subject: Re: Review Request 58760: Added default secret fetcher module. From: Kapil Arya To: Jie Yu , Vinod Kone , Gilbert Song Cc: mesos Date: Fri, 28 Apr 2017 18:50:48 -0000 Message-ID: <20170428185048.16779.1552@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kapil Arya X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58760/ X-Sender: Kapil Arya References: <20170426233846.64641.74396@reviews-vm2.apache.org> In-Reply-To: <20170426233846.64641.74396@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/secret/fetcher.hpp X-ReviewBoard-Diff-For: src/secret/fetcher.cpp Reply-To: Kapil Arya X-ReviewRequest-Repository: mesos --===============0775761638376213033== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58760/ ----------------------------------------------------------- (Updated April 28, 2017, 2:50 p.m.) Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Bugs: MESOS-7418 https://issues.apache.org/jira/browse/MESOS-7418 Repository: mesos Description (updated) ------- The default module doesn't attempt to interpret Secret::reference and simply returns Secret::value. Diffs (updated) ----- src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 src/secret/fetcher.hpp PRE-CREATION src/secret/fetcher.cpp PRE-CREATION Diff: https://reviews.apache.org/r/58760/diff/2/ Changes: https://reviews.apache.org/r/58760/diff/1-2/ Testing ------- Thanks, Kapil Arya --===============0775761638376213033==--